[patch 04/39] remove implied vm_ops check

From: blaisorblade
Date: Fri Aug 12 2005 - 13:18:18 EST



From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>

If !vma->vm-ops we already BUG above, so retesting it is useless. The compiler
cannot optimize this because BUG is a macro and is not thus marked noreturn;
that should possibly be fixed.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>
---

linux-2.6.git-paolo/mm/memory.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN mm/memory.c~remove-implied-vm_ops-check mm/memory.c
--- linux-2.6.git/mm/memory.c~remove-implied-vm_ops-check 2005-08-11 11:05:20.000000000 +0200
+++ linux-2.6.git-paolo/mm/memory.c 2005-08-11 11:05:47.000000000 +0200
@@ -1933,7 +1933,7 @@ static int do_file_page(struct mm_struct
* Fall back to the linear mapping if the fs does not support
* ->populate:
*/
- if (!vma->vm_ops || !vma->vm_ops->populate ||
+ if (!vma->vm_ops->populate ||
(write_access && !(vma->vm_flags & VM_SHARED))) {
pte_clear(mm, address, pte);
return do_no_page(mm, vma, address, write_access, pte, pmd);
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/