Re: [PATCH] Don't use a klist for drivers' set-of-devices

From: Alan Stern
Date: Fri Aug 12 2005 - 08:49:28 EST


On Thu, 11 Aug 2005, Dmitry Torokhov wrote:

> Hmm, so what do I do in the following scenario - I have a serio port
> (AUX) that has a synaptics touchpad bound to it which is driven by
> psmouse driver. psmouse driver registers a child port (synaptics
> pass-through) during probe call. The child port is also driven by
> psmouse module - but it looks like it will deadlock when binding.

Dmitry's point is well founded. Greg, I want to retract that klist patch
(as536). I'll send in a revised version before long.

It looks like the best approach will simply be to eliminate the driver's
list of bound devices altogether. That should make Christoph happy -- no
klist, no list, no nothing! :-) The list hardly ever gets used, mainly
when the driver is unloaded. We can already get the same effect by
iterating over the bus's list of devices and skipping everything not bound
to the driver.

This will eliminate a whole set of races and make the code more
transparent (I hope).

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/