Re: [patch 3/8] [PATCH] x86_64: Fixing smpboot timing problem

[Eric W. Biederman]

Chris Wright <chrisw@xxxxxxxx> writes:

> * Andi Kleen (ak@xxxxxxx) wrote:
>> >  static void __cpuinit tsc_sync_wait(void)
>> >  {
>> >  	if (notscsync || !cpu_has_tsc)
>> >  		return;
>> > - printk(KERN_INFO "CPU %d: Syncing TSC to CPU %u.\n", smp_processor_id(),
>> > -			boot_cpu_id);
>> > -	sync_tsc();
>> > +	sync_tsc(boot_cpu_id);
>> 
>> I actually found a bug in this today. This should be sync_tsc(0), not
> sync_tsc(boot_cpu_id)
>> Can you just fix it in your tree or should I submit a new patch? 
>
> I'll fix it locally.  Thanks for the heads-up.

Someone needs to send the patch to Linus for 2.6.13 as well.  Is someone
else going to or should I.  I knew I was confused about physical versus
logical apic ids when I generated the patch.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/