Re: [PATCH] Don't use a klist for drivers' set-of-devices

[Greg KH]

On Wed, Aug 10, 2005 at 04:56:08PM -0400, Alan Stern wrote:
> Greg and Pat:
> 
> This patch (as536) simplifies the driver-model core by replacing the klist 
> used to store the set of devices bound to a driver with a regular list 
> protected by a mutex.  It turns out that even with a klist, there are too 
> many opportunities for races for the list to be used safely by more than 
> one thread at a time.  And given that only one thread uses the list at any 
> moment, there's no need to add all the extra overhead of making it a 
> klist.

Hm, but that was the whole reason to go to a klist in the first place.

> This version of the patch addresses the concerns raised earlier by Pat:  
> the list and mutex have been given more succinct names, and the obscure
> special-case code in device_attach has been replaced with a FIXME comment.  
> Note that the new iterators in driver.c could easily be changed to use
> list_for_each_entry_safe and list_for_each_entry, if the functions didn't
> offer the feature of starting in the middle of the list.  If no callers
> use that feature, it should be removed.

Pat, any opinions on this patch?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/