Re: [PATCH/RFT 2/5] CLOCK-Pro page replacement

From: Rik van Riel
Date: Wed Aug 10 2005 - 15:38:34 EST


On Wed, 10 Aug 2005, David S. Miller wrote:
> From: Rik van Riel <riel@xxxxxxxxxx>
> Date: Wed, 10 Aug 2005 16:02:18 -0400
>
> > --- linux-2.6.12-vm.orig/fs/proc/proc_misc.c
> > +++ linux-2.6.12-vm/fs/proc/proc_misc.c
> > @@ -219,6 +219,20 @@ static struct file_operations fragmentat
> > .release = seq_release,
> > };
> >
> > +extern struct seq_operations refaults_op;
>
> Please put this in linux/mm.h or similar, so that we'll get proper
> type checking of the definition in nonresident.c

The reason it is in fs/proc/proc_misc.c is that the rest of
these definitions are there.

I agree with you though, it would be a good thing if they
moved into a header file.

--
All Rights Reversed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/