Re: Patch of a new driver for kernel 2.4.x that need review

[Pekka Enberg]

On 8/8/05, Mark Gross <mgross@xxxxxxxxxxxxxxx> wrote:
> Please tell me what you think :)

The formatting seems completely messed up presumably because of your
email client.

On 8/8/05, Mark Gross <mgross@xxxxxxxxxxxxxxx> wrote:
> + alarm_events = kcalloc(sizeof(struct tlclk_alarms), 1, GFP_KERNEL);

The first argument to kcalloc() is number of elements and the second
one is size of one element. In this case, however, use the new
kzalloc() which can be found in 2.6.13-rc5-mm1.

                                                   Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/