Re: [PATCH C&C] gdth: remove GDTIOCTL_OSVERS

From: Adrian Bunk
Date: Sun Aug 07 2005 - 20:40:47 EST


On Mon, Aug 08, 2005 at 02:28:29AM +0400, Alexey Dobriyan wrote:

>...
> --- linux-vanilla/drivers/scsi/gdth.c 2005-08-08 02:16:47.000000000 +0400
> +++ linux-gdth/drivers/scsi/gdth.c 2005-08-08 02:19:59.000000000 +0400
> @@ -5411,18 +5411,6 @@ static int gdth_ioctl(struct inode *inod
> return -EFAULT;
> break;
> }
> -
> - case GDTIOCTL_OSVERS:
> - {
> - gdth_ioctl_osvers osv;
> -
> - osv.version = (unchar)(LINUX_VERSION_CODE >> 16);
> - osv.subversion = (unchar)(LINUX_VERSION_CODE >> 8);
> - osv.revision = (ushort)(LINUX_VERSION_CODE & 0xff);
> - if (copy_to_user(argp, &osv, sizeof(gdth_ioctl_osvers)))
> - return -EFAULT;
> - break;
> - }
>...

Not that I'd like this, but you know that this is a userspace-visible
change?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/