Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

From: Jiri Slaby
Date: Sat Aug 06 2005 - 19:18:38 EST


Domen Puncer napsal(a):

You have much bigger chances of someone reviewing the patch if you
at least split code changes and whitespace/type cleanups. 65k is a lot.


Ok, 3 patches:
http://www.fi.muni.cz/~xslaby/lnx/isi_main.txt
this changes many lines of code, adds hotplug, firmware loading, add one fixme, because i have really no idea, what device feed to request_firmware when isa card is used

http://www.fi.muni.cz/~xslaby/lnx/isi_us.txt
unsigned short changed to u16 and similar, where it expect sized operands

http://www.fi.muni.cz/~xslaby/lnx/isi_w.txt
changes trying to convert code into CodingStyle
removed trailing spaces, some lines longer than 80 split

--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@xxxxxxxxx ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/