Re: [PATCH] 8/8 Create MMU 2/3 level accessors in the sub-arch layer (i386)

From: Christoph Hellwig
Date: Sat Aug 06 2005 - 06:58:33 EST


On Sat, Aug 06, 2005 at 01:37:31PM +0200, Andi Kleen wrote:
> Zachary Amsden <zach@xxxxxxxxxx> writes:
>
> > i386 Transparent paravirtualization sub-arch patch #8.
> >
> > Transparent paravirtualization support for MMU operations.
> >
> > All operations which update live page table entries have been moved to the
> > sub-architecture layer. Unfortunately, this required yet another parallel set
> > of pgtable-Nlevel-ops.h files, but this avoids the ugliness of having to use
> > #ifdef's all of the code.
> >
> > This is pure code motion. Anything else would be a bug.
>
> I think that patch is really ugly - it makes hacking VM on i386
> even more painful than it already is because the convolutes the file
> structure even more. Hope it is not applied.

Especially as there's been no user shown for it, similar to all the other
ugly patches from vmware.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/