Re: [PATCH] 6700/6702PXH quirk

From: Kristen Accardi
Date: Fri Aug 05 2005 - 17:44:03 EST


On Fri, 2005-08-05 at 15:26 -0700, Andrew Morton wrote:
> Kristen Accardi <kristen.c.accardi@xxxxxxxxx> wrote:

> > + if (!quirk)
> > + return -ENOMEM;
> > +
> > + INIT_LIST_HEAD(&quirk->list);
> > + quirk->dev = dev;
> > + list_add(&quirk->list, &msi_quirk_list);
> > + return 0;
> > +}
>
> Does the list not need any locking?

Actually, I'm glad you asked that question because I was wondering that
myself. The devices are added to the list at boot time, and after that
time, the list will never change. Does PCI enumeration happen on all
processors? I thought maybe it only happened on one. In that case we
don't need a lock I don't think.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/