[patch] fsnotify: hook on removexattr, too

From: Robert Love
Date: Fri Aug 05 2005 - 14:57:42 EST



On Fri, 2005-08-05 at 19:07 +0100, marijn ros wrote:

> I got wondering, why does fs_notify_xattr get called from setxattr in fs/xattr.c, but
> not from removexattr that is below it in the same file? Both seem to make changes to
> xattrs and both are exported as system calls.

We should.

Robert Love


Add fsnotify_xattr() hook to removexattr().

Signed-off-by: Robert Love <rml@xxxxxxxxxx>

fs/xattr.c | 2 ++
1 files changed, 2 insertions(+)

diff -urN linux-2.6.13-rc5/fs/xattr.c linux/fs/xattr.c
--- linux-2.6.13-rc5/fs/xattr.c 2005-08-05 15:49:17.000000000 -0400
+++ linux/fs/xattr.c 2005-08-05 15:53:45.000000000 -0400
@@ -307,6 +307,8 @@
down(&d->d_inode->i_sem);
error = d->d_inode->i_op->removexattr(d, kname);
up(&d->d_inode->i_sem);
+ if (!error)
+ fsnotify_xattr(d);
}
out:
return error;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/