Re: assertion (cnt <= tp->packets_out) failed

From: David S. Miller
Date: Fri Aug 05 2005 - 11:33:20 EST


From: John Bäckstrand <sandos@xxxxxxx>
Date: Fri, 05 Aug 2005 17:53:11 +0200

> KERNEL: assertion (cnt <= tp->packets_out) failed at
> net/ipv4/tcp_input.c (1476)

I suspect this is a side effect of some changes Herbert Xu and
myself did to fix some other bugs.

Herbert, I think there are serious consequences for changing the
TSO counts for packets we have sent out already. This mucks up
all of the loss packet counts, which triggers asserts all over
in tcp_input.c

As you may note, we have all of this special code when we fragment
packets that updates all of the counters properly. And we're
not doing that for the new code that reinits the TSO count when
the MSS is found to no longer match.

It therefore may be desirable to keep Herbert's fix in there, but
back out my changes until they can be reimplemented correctly.

Herbert?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/