Re: [patch 2.6.13-rc4] fix get_user_pages bug

From: Linus Torvalds
Date: Wed Aug 03 2005 - 11:41:34 EST




On Wed, 3 Aug 2005, Linus Torvalds wrote:
>
> Ok, I applied this because it was reasonably pretty and I liked the
> approach. It seems buggy, though, since it was using "switch ()" to test
> the bits (wrongly, afaik), and I'm going to apply the appended on top of
> it. Holler quickly if you disagreee..

Another problem I just thought of.

What about PROT_NONE pages? Afaik, they have _exactly_ the same issue on
the read side as a PROT_READ page has on the write side: pte_read() may
fail on them.

What makes us not get into an infinite loop there?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/