Re: 2.6.13-rc3-mm3

From: Ivan Kokshaysky
Date: Tue Aug 02 2005 - 16:33:18 EST


On Tue, Aug 02, 2005 at 10:11:40AM -0700, Linus Torvalds wrote:
> So I think it would be much easier to just make the change in
> "pci_bus_alloc_resource()", and say that if the parent resource that we're
> testing starts at some non-zero value, we just use that instead of "min"
> when we call down to allocate_resource(). That gets it for MEM resources
> too.

Cool! I think it's the way to go.

> Something like the following (also _totally_ untested, but even simpler
> than yours). It basically says: if the parent resource starts at non-zero,
> we use that as the starting point for allocations, otherwise the passed-in
> value.

Tested on alpha. Initially I was concerned a bit about architectures
where resources _never_ start at zero (due to some specific bus to
resource conversions), but this change is just a no-op for them.

> That, together with changing PCIBIOS_MIN_IO to 0x2000 (or even 0x4000)
> might be the ticket...

Definitely 0x4000. Then we can get rid of PCIBIOS_MIN_CARDBUS_IO which
was introduced exactly for this reason, I guess.

Ivan.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/