Re: Calling suspend() in halt/restart/shutdown -> not a good idea

From: Marc Ballarin
Date: Mon Aug 01 2005 - 13:47:42 EST


On Mon, 01 Aug 2005 17:09:31 +0200
Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:

> Hi !
>
> Why are we calling driver suspend routines in these ? This is _not_ a
> good idea ! On various machines, the mecanisms for shutting down are
> quite different from suspend/resume, and current drivers have too many
> bugs to make that safe. I keep getting all sort of reports of machines
> not shutting down anymore.

For example, my Centrino laptop will restart instead of power down with
-mm kernels.

To "fix" this I can either:
- unplug power. Shutdown works when on battery power.
- attach an external USB hard disk => power down always works.
- remove device_suspend(PMSG_SUSPEND) => power down always works.

Marc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/