Re: [PATCH] random : prefetch the whole pool, not 1/4 of it

[Matt Mackall]

On Fri, Jul 29, 2005 at 12:26:11AM +0200, Eric Dumazet wrote:
> Hi Matt
> 
> Could you check this patch and apply it ?
> 
> Thank you
> 
> Eric
> 
> [RANDOM] : prefetch the whole pool, not 1/4 of it,
>            (pool contains u32 words, not bytes)

You probably want r->poolinfo->poolwords as wordmask is off by one?
Please use "x * 4" rather than "x*4" too.


> --- linux-2.6.13-rc3/drivers/char/random.c	2005-07-13 06:46:46.000000000 +0200
> +++ linux-2.6.13-rc3-ed/drivers/char/random.c	2005-07-29 00:11:24.000000000 +0200
> @@ -469,7 +469,7 @@
>  	next_w = *in++;
>  
>  	spin_lock_irqsave(&r->lock, flags);
> -	prefetch_range(r->pool, wordmask);
> +	prefetch_range(r->pool, wordmask*4);
>  	input_rotate = r->input_rotate;
>  	add_ptr = r->add_ptr;
>  


-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/