On 7/24/05, randy_dunlap <rdunlap@xxxxxxxxxxxx> wrote:I have to admit that I like paranoid programming, and would rather see this look for "kernel_hz=" then convert the digits after to an integer and validate that. It would catch invalid values far better, allow other values to be either implemented as best as is possible if desired, and NOT ignore invalid values if they didn't match these predefined strings.
On Fri, 15 Jul 2005 05:46:44 +0200 Jesper Juhl wrote:ouch. You are right - thanks. I'll be sure to fix that.
+static int __init jiffies_increment_setup(char *str)BTW, if someone enters "kernel_hz=1000", this check (above) for "100"
+{
+ printk(KERN_NOTICE "setting up jiffies_increment : ");
+ if (str) {
+ printk("kernel_hz = %s, ", str);
+ } else {
+ printk("kernel_hz is unset, ");
+ }
+ if (!strncmp("100", str, 3)) {
matches (detects) 100, not 1000.
I haven't had time to look more at this little thing for the last few
days, but I'll get back to it soon. Thank you for the feedback.