Re: Why build empty object files in drivers/media?

[Sam Ravnborg]

On Thu, Jul 21, 2005 at 11:06:21PM -0400, Chuck Ebbert wrote:
> 
> I have this in my .config file for 2.6.13-rc3:
> 
> 
> #
> # Multimedia devices
> #
> # CONFIG_VIDEO_DEV is not set
> 
> #
> # Digital Video Broadcasting Devices
> #
> # CONFIG_DVB is not set
> 
> 
> And yet these completely empty files are being built:
> 
> ...
kbuild is told to visit these directories - and then it build an empty
.o file to make linking step possible.
The only solution is to tell kbuild not to visit these directories
unless they are in real use.
Following untested patch should do the trick. But the media people must
check if before being applied since I have only taken a brief look at
the Kconfig and Makefile files.

	Sam

diff --git a/drivers/media/Makefile b/drivers/media/Makefile
--- a/drivers/media/Makefile
+++ b/drivers/media/Makefile
@@ -2,4 +2,7 @@
 # Makefile for the kernel multimedia device drivers.
 #
 
-obj-y        := video/ radio/ dvb/ common/
+obj-y                   := common/
+obj-$(CONFIG_VIDEO_DEV) := video/
+obj-$(CONFIG_VIDEO_DEV) := radio/
+obj-$(CONFIG_DVB)       := dvb/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/