Re: [PATCH] generic_file_sendpage

[Jan Blunck]

Linus Torvalds wrote:
> "sendfile()" in general I think has been a mistake. It's too specialized,
> and the interface has always sucked.

Ok, you're right. I will have a look at the pipe buffer stuff.

> As Andrew pointed out, it actually
> needs to limit the number of buffers in flight partly because otherwise 
> you have uninterruptible kernel work etc etc.

Hmm, sendfile() uses do_generic_mapping_read() which is calling the 
file_send_actor() per page. The actor calls ->sendpage(). I don't see 
any situation how this could lead to uninterruptible kernel work when 
the sendpage() itself is checking for signals. There are only 2 pages in 
flight in this case.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/