Re: Patch of a new driver for kernel 2.4.x that need review
From: Pekka J Enberg
Date: Thu Jul 07 2005 - 02:01:29 EST
Hi Dmitry,
Mark Gross writes:
> > +
> > +/* 0 = Dynamic allocation of the major device number */
> > +#define TLCLK_MAJOR 252
Pekka J Enberg <penberg@xxxxxxxxxxxxxx> wrote:
> Enums, please.
>
Dmitry Torokhov writes:
But not here - it is a single constant, not a value of a distinct type.
Fair enough, "static const int" would work here too. Defines should be
avoided because they allow you to override a value without ever noticing it.
Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/