Re: -mm -> 2.6.13 merge status

From: Jörn Engel
Date: Mon Jun 27 2005 - 03:24:56 EST


On Mon, 27 June 2005 10:49:19 +0300, Pekka J Enberg wrote:
>
> #ifndef HAVE_ARCH_BUG_ON
> -#define BUG_ON(condition) do { if (unlikely((condition)!=0)) BUG(); } while(0)
> +#define BUG_ON(condition) do { \
> + if (unlikely((condition) != 0)) { \
> + printk("kernel BUG '%s' at %s:%d!\n", #condition, __FILE__, __LINE__); \
> + panic("BUG!"); \
> + } \
> +} while(0)
> #endif

o How about those architectures, where BUG() and panic() are not the
same thing?
o Embedded people might prefer not to have the additional string
constants in the kernel. Some config option would ease their wrath.
And no, not all embedded people #define BUG() to nothing.

Jörn

--
Happiness isn't having what you want, it's wanting what you have.
-- unknown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/