Re: Patch of a new driver for kernel 2.4.x that need review

[Pekka Enberg]

On 6/22/05, Bouchard, Sebastien <Sebastien.Bouchard@xxxxxxxxxxxxxx> wrote:
> +static int __init
> +tlclk_init(void)
> +{

[snip]

> +       if (check_region(TLCLK_BASE, 8)) {
> +               printk(KERN_ERR
> +                      "telclock: I/O region already used by another
> driver!\n");
> +               return -EBUSY;
> +       } else {
> +               request_region(TLCLK_BASE, 8, "telclock");

request_region can fail too so you'd better handle that.

                               Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/