Re: [PATCH] Fix Reiser4 Dependencies

[Edward Shishkin]

Andrew James Wade wrote:

> > Andrew James Wade wrote:
> >
> >    
> >
> > > *    ZLIB_INFLATE is not visible in menuconfig. Reiser4 should probably
> > >    just select it like the other filesystems do.
> > >      
> The issue I had here was that Reiser4 wasn't appearing in menuconfig for
> me as I did not have ZLIB_INFLATE set, and the ZLIB_INFLATE option wasn't
> appearing either (I think it's because it doesn't have a prompt). I just
> followed the pattern for all other filesystems referencing ZLIB_INFLATE,
> and the comment in lib/Kbuild suggests this is the proper approach:
>
> | #
> | # compression support is select'ed if needed
> | #
>
>  
>
> > > *    Reiser4 also depends on ZLIB_DEFLATE.
> > >      
> I was getting linker errors:
>
> | fs/built-in.o(.text+0x8f465): In function `gzip1_alloc':
> | fs/reiser4/plugin/compress/compress.c:59: undefined reference to `zlib_deflate_workspacesize'
> | fs/built-in.o(.text+0x8f475): In function `gzip1_alloc':
> | include/asm/string.h:361: undefined reference to `zlib_deflate_workspacesize'
> | fs/built-in.o(.text+0x8f64e): In function `gzip1_compress':
> | fs/reiser4/plugin/compress/compress.c:167: undefined reference to `zlib_deflateInit2_'
> | fs/built-in.o(.text+0x8f661):fs/reiser4/plugin/compress/compress.c:174: undefined reference to `zlib_deflateReset'
> | fs/built-in.o(.text+0x8f697):fs/reiser4/plugin/compress/compress.c:184: undefined reference to `zlib_deflate'
>
> select'ing ZLIB_DEFLATE fixed them.
>
> Reiser4 is working for me after the two changes.
>
> HTH,
> Andrew
>  

Hello,
ZLIB_INFLATE/DEFLATE  will be selected by special reiser4 related 
configuration
option "Enable reiser4 compression plugins of gzip family" 
(REISER4_ZLIB), but
since this kind of support was discussed, it is in our working 
repository for a while..

Anyway thanks,
Edward.

>  
>
> > > signed-off-by: Andrew Wade <ajwade@xxxxxxxxxxxxxxxxxxx>
> > >
> > > --- 2.6.12-mm1/fs/reiser4/Kconfig	2005-06-20 07:38:22.087653000 -0400
> > > +++ linux/fs/reiser4/Kconfig	2005-06-20 08:01:28.914324250 -0400
> > > @@ -1,6 +1,8 @@
> > > config REISER4_FS
> > > 	tristate "Reiser4 (EXPERIMENTAL)"
> > > -	depends on EXPERIMENTAL && !4KSTACKS && ZLIB_INFLATE
> > > +	depends on EXPERIMENTAL && !4KSTACKS
> > > +	select ZLIB_INFLATE
> > > +	select ZLIB_DEFLATE
> > > 	help
> > > 	  Reiser4 is a filesystem that performs all filesystem operations
> > > 	  as atomic transactions, which means that it either performs a
> > >      
>
>
>  

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/