Re: [PATCH 1/6] new timeofday core subsystem for -mm (v.B3)

[Ulrich Windl]

On 20 Jun 2005 at 12:22, Roman Zippel wrote:

[...]
> This patch is really damned hard to read as it changes too many things at 
> once. Maybe it does some necessary cleanups, but they are hard see, as 
> they pretty much get lost in all the functional changes.
> I'm pretty close to suggest to reject this patch until it clearly 
> separates new functionality from cleanups. If the current system is broken 

Roman,

it seems you don't like the patch for some personal reasons, and now your are 
trying to find arguments against it. The best method to get the perfomance 
implications is trying it (the patched kernel).

> fix it first, if the current system is a mess clean it up first, but 
> don't mix these two steps, unless you want to introduce more broken mess.

If you introduce something new (higher resolution clock), you should start with 
something clean. Just hacking it in the first attempt, anf then making it 
beautiful in a second attempt is a waste of time IMHO.

Regards,
Ulrich

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/