Re: [patch 1/2] vm early reclaim orphaned pages (take 2)

From: Andrew Morton
Date: Mon Jun 20 2005 - 02:33:31 EST


Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
>
> How about this?
>

It might be good, it's hard to tell.

Performance testing is needed.

> --- linux-2.6.orig/mm/swap.c 2004-12-25 08:34:31.000000000 +1100
> +++ linux-2.6/mm/swap.c 2005-06-20 17:20:28.216728238 +1000
> @@ -87,7 +87,7 @@
> spin_lock_irqsave(&zone->lru_lock, flags);
> if (PageLRU(page) && !PageActive(page)) {
> list_del(&page->lru);
> - list_add_tail(&page->lru, &zone->inactive_list);
> + list_move_tail(&page->lru, &zone->inactive_list);
> inc_page_state(pgrotated);
> }
> if (!test_clear_page_writeback(page))
> @@ -97,6 +97,32 @@
> }

Correctness testing is needed too ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/