Re: [PATCH] Small kfree cleanup, save a local variable.

From: Jesper Juhl
Date: Sun Jun 19 2005 - 15:20:31 EST


On 6/19/05, Chris Wright <chrisw@xxxxxxxx> wrote:
> * Jesper Juhl (juhl-lkml@xxxxxx) wrote:
> > Here's a patch with a small improvement to kernel/auditsc.c .
> > There's no need for the local variable struct audit_entry *e ,
> > we can just call kfree directly on container_of() .
> > Patch also removes an extra space a little further down in the file.
>
> Please Cc: linux-audit@xxxxxxxxxx on audit patches.

I didn't find that address in MAINTAINERS nor in the source file. I
had no idea it existed. Perhaps it ought to be listed in MAINTAINERS
somewhere...


> I tend to agree
> with Michael, it's optimized away, and readable as is.
>
Fair enough, we'll just leave it as is :)


--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/