Re: [PATCH] pci: don't override drv->shutdown unconditionally

[Greg KH]

On Fri, Jun 17, 2005 at 08:51:04PM +0200, Christoph Hellwig wrote:
> On Fri, Jun 17, 2005 at 11:49:14AM -0700, Greg KH wrote:
> > On Fri, Jun 17, 2005 at 08:30:57PM +0200, Christoph Hellwig wrote:
> > > There are many drivers that have been setting the generic driver
> > > model­level shutdown callback, and pci thus must not override it.
> > > 
> > > Without this patch we can have really bad data loss on various
> > > raid controllers.
> > 
> > Without the kexec patch?
> 
> On shutdown.  I don't know why you're talking about kexec here.

Because of the previous kexec comments on the linux-scsi list.

> > So, why are these drivers setting the shutdown function in the first
> > place if they don't want it to be called? 
> 
> They _do_ want it called.  They set the driver-model level one because
> there hasn't been a pci-level one until a few years ago.

So they are setting two callbacks?  Have a pointer to any driver that
does this?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/