Re: [PATCH 0/1] VFS: memory leak in do_kern_mount()

[Gerald Schaefer]

On Fri, 2005-06-17 at 15:17 +0200, Gerald Schaefer wrote:
> [PATCH 0/1] VFS: memory leak in do_kern_mount()
> There is a memory leak during mount when CONFIG_SECURITY is enabled and mount
> options are specified.
> 
> Signed-off-by: Gerald Schaefer <geraldsc@xxxxxxxxxx>
> ---
> 
> diff -pruN linux-2.6-git/fs/super.c linux-2.6-git_xxx/fs/super.c
> --- linux-2.6-git/fs/super.c    2005-06-16 20:00:26.000000000 +0200
> +++ linux-2.6-git_xxx/fs/super.c        2005-06-17 14:18:06.000000000 +0200
> @@ -835,6 +835,7 @@ do_kern_mount(const char *fstype, int fl
>         mnt->mnt_parent = mnt;
>         mnt->mnt_namespace = current->namespace;
>         up_write(&sb->s_umount);
> +       free_secdata(secdata);
>         put_filesystem(type);
>         return mnt;
>  out_sb:

Sorry, there was a whitespace accident and the above patch would not apply.
Here is the fixed version:

diff -pruN linux-2.6-git/fs/super.c linux-2.6-git_xxx/fs/super.c
--- linux-2.6-git/fs/super.c	2005-06-16 20:00:26.000000000 +0200
+++ linux-2.6-git_xxx/fs/super.c	2005-06-17 14:18:06.000000000 +0200
@@ -835,6 +835,7 @@ do_kern_mount(const char *fstype, int fl
 	mnt->mnt_parent = mnt;
 	mnt->mnt_namespace = current->namespace;
 	up_write(&sb->s_umount);
+	free_secdata(secdata);
 	put_filesystem(type);
 	return mnt;
 out_sb:


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/