Re: [patch 2.6.12-rc3] Adds persistent entryies using request_firmware_nowaitManuel Estrada Sainz <ranty@debian.org>,

[Greg KH]

On Wed, Jun 15, 2005 at 07:34:14PM -0500, Abhay Salunke wrote:
> This is a patch to make the /sys/class/firmware entries persistent. 
> This has been tested with dell_rbu; dell_rbu was modified to not call
> request_firmware_nowait again form the callback function. 
> 
> The new mechanism to make the entries persistent is as follows
> 1> echo 0 > /sys/class/firmware/timeout
> 2> echo 2 > /sys/class/firmware/xxx/loading
> 
> step 1 prevents timeout to occur , step 2 makes the entry xxx persistent
> 
> if we want to remove persistence then do this
> ech0 -2 > /sys/class/firmware/xxx/loading

Hm, those are some mighty "magic" numbers that will be tough for people
to realize exactly what they mean.  Try adding a "persistant" file
instead.

> + /*
> + * 2005-06-15: 	Abhay Salunke <abhay_salunke@xxxxxxxx>
> + *		Added firmware persistent when request_firmware_nowait.
> + *		is called. 
> + */

Don't add changelog comments to .c files.  That belongs in the git tree,
not in the code itself.

Also, your use of tabs and spaces are wrong in a lot of places...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/