Re: [PATCH] pci-sysfs: backport fix for 2.6.11.12

From: Greg KH
Date: Tue May 31 2005 - 14:18:08 EST


On Tue, May 31, 2005 at 07:36:19PM +0300, Michael S. Tsirkin wrote:
> Greg, before 2.6.12, pci_write_config in pci-sysfs.c was broken, causing
> incorrect data being written to the configuration register,
> which in the case of my userspace driver results in system failure.
>
> This has been fixed in 2.6.12-rc5:
>
> http://www.kernel.org/diff/diffview.cgi?file=%2Fpub%2Flinux%2Fkernel%2Fv2.6%2Ftesting%2Fpatch-2.6.12-rc5.bz2;z=2656
>
> Would you please consider merging the fix for 2.6.11.12 as well?

Would you care to split out only the proper part for that fix? There
are a few different patches in that link above.

> Alternatively (since there were multiple other changes in pci-sysfs.c), here's
> a small patch to fix just this issue.

I don't think this fixes the problem properly. Can you verify it?
Also, this is only a 64bit issue, right? What platform are you seeing
this on?

And, any patch that you want to propose for the -stable releases, needs
to be sent to the stable@xxxxxxxxxx email alias.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/