Re: [BUG] oops while completing async USB via usbdevio

From: Harald Welte
Date: Tue May 31 2005 - 03:11:12 EST


On Tue, May 31, 2005 at 01:07:03AM +0200, Oliver Neukum wrote:
>
> > and it prints "p->sighand == NULL" every time I exit a program while
> > using the usbdevio based driver.
> >
> > consequently, the following patch 'fixed' the problem. Please do not
> > consider this as a real fix, since there's certainly still a race
> > condition left. Please use it as a hint to correctly fix the problem.
>
> It would be cleaner to terminate all URBs a task has submitted when the
> task terminates.

so for every task termination, we do a linear search over the global
list of pending URB's and terminate those where urb->task ==
taks_to_kill? Sounds a bit expensive, especially since you don't know
(before iteration) whether that task has actually ever dealt with
usbdevio or not.

--
- Harald Welte <laforge@xxxxxxxxxxxx> http://gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)

Attachment: pgp00000.pgp
Description: PGP signature