Re: 2.6.12-rc5-mm1: drivers/media/dvb/dvb-usb/a800.c compile error

From: Patrick Boettcher
Date: Mon May 30 2005 - 03:39:00 EST


Hi,

On Sun, 29 May 2005, Adrian Bunk wrote:
It seems this patch is responsible for the following compile error with
gcc 2.95:
<-- snip -->

...
CC drivers/media/dvb/dvb-usb/a800.o
In file included from drivers/media/dvb/dvb-usb/dibusb.h:15,
from drivers/media/dvb/dvb-usb/a800.c:16:
drivers/media/dvb/dvb-usb/dvb-usb.h:196: field `devices' has incomplete type
...
make[4]: *** [drivers/media/dvb/dvb-usb/a800.o] Error 1

<-- snip -->

The attached patch solves the problem by adding a '0' to the array declaration. I don't know if this is ethically correct, but I saw it in some v4l-code, so I assume it is.

Signed-off-by: Patrick Boettcher <pb@xxxxxxxxxxx>


Thanks for reporting,
Patrick.

--
Mail: patrick.boettcher@xxxxxxx
WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/Index: linux/drivers/media/dvb/dvb-usb/dvb-usb.h
===================================================================
RCS file: /cvs/linuxtv/dvb-kernel/linux/drivers/media/dvb/dvb-usb/dvb-usb.h,v
retrieving revision 1.16
diff -u -r1.16 dvb-usb.h
--- linux/drivers/media/dvb/dvb-usb/dvb-usb.h 2 May 2005 12:48:01 -0000 1.16
+++ linux/drivers/media/dvb/dvb-usb/dvb-usb.h 30 May 2005 08:24:55 -0000
@@ -193,7 +193,7 @@
} urb;

int num_device_descs;
- struct dvb_usb_device_description devices[];
+ struct dvb_usb_device_description devices[0];
};