Re: 2.6.12-rc5-mm1: drivers/usb/atm/speedtch.c: gcc 2.95 compileerror

[Duncan Sands]

> > Hi Adrian, it looks like gcc 2.95 doesn't like this kind of macro
> > 
> >  #define atm_info(instance, format, arg...)	\
> >  	atm_printk(KERN_INFO, instance , format , ## arg)
> > 
> >  being called with only two arguments.  I don't know what
> >  the best fix is, but this does the trick:
> 
> Nope.  There's a bug in gcc-2.95.x macro expansion, and here it bites us in
> atm_printk():
> 
> printk(level "ATM dev %d: " format , (instance)->atm_dev->number, ## arg)
> 
> the workaround is to add a space before that final comma:

Yes, this fixes the problem.

Thanks a lot!

Duncan.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/