Re: 2.6.12-rc5-mm1 - missing #define SECTIONS_SHIFT in sparsemem

[Andy Whitcroft]

Valdis.Kletnieks@xxxxxx wrote:
> sparsemem-memory-model.patch references SECTIONS_SHIFT without defining it.
> 
> Caught this while compiling with -Wundef, causes lots of warnings
> when it gets used in include/linux/mm.h.  The appended patch Works For Me,
> although I wonder if the *real* problem isn't a missing '#ifdef CONFIG_SPARSEMEM'
> around the code that uses it in mm.h.  
>  
> Signed-Off-By: valdis.kletnieks@xxxxxx
> 
> --- linux-2.6.12-rc5-mm1/include/linux/mmzone.h.ifdef	2005-05-27 15:12:26.000000000 -0400
> +++ linux-2.6.12-rc5-mm1/include/linux/mmzone.h	2005-05-27 16:26:40.000000000 -0400
> @@ -568,6 +568,7 @@ static inline int pfn_valid(unsigned lon
>  void sparse_init(void);
>  #else
>  #define sparse_init()	do {} while (0)
> +#define SECTIONS_SHIFT	0
>  #endif /* CONFIG_SPARSEMEM */
>  
>  #ifdef CONFIG_NODES_SPAN_OTHER_NODES

Odd.  I guess there must be a reference from an unused function to this
define when SPARSEMEM is off.  Can you send me your .config please and
I'll have a look.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/