Re: PATCH : ppp + big-endian = kernel crash

From: David S. Miller
Date: Sun May 29 2005 - 15:56:32 EST


From: "Philippe De Muyter" <phdm@xxxxxxxxx>
Date: Sun, 29 May 2005 21:48:42 +0200 (CEST)

> + /* If the address of the packet is odd now, fix it. */
> + if ((unsigned long)skb->data & 1) {
> + unsigned char *p;

And now it will crash when a packet is only 2-byte aligned
when the input packet processing does the first access
to the IP address in the packet header.

Please make your m68k port handle unaligned memory accesses
in kernel mode properly instead.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/