Re: [PATCH] DRM depends on ???

[Geert Uytterhoeven]

On Sun, 29 May 2005, Dave Airlie wrote:
> > > The whole dependancy seems like nonsense to me.
> > > I think
> > >
> > >     depends on PCI
> > >
> > > is a lot more sensible.
> >
> > I think the original reasoning was something like this:
> >
> > If DRM is built-in, then AGP _must_ be built-in or not included at all,
> > modular
> > won't work.  If DRM is modular or not built, then AGP may be built-in,
> > modular,
> > or not built at all.
> >
> > The "depends on AGP || AGP=n" means that if DRM=y, then AGP=y or AGP=n, and if
> > DRM=m or DRM=n, then AGP=y or AGP=m or AGP=n.
> >
> > Yes it's unclear and yes it should probably be documented in a comment
> > somewhere.
> 
> What Kyle said is the correct answer... we either keep this lovely
> construct (I'll add a comment for 2.6.13) or we go back to the old
> intermodule or module_get stuff... DRM built-in with modular AGP is always
> wrong... or at least I'll get a hundred e-mails less every month if I
> say it is ..

And what if we don't have AGP at all? Or no PCI?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/