Re: [PATCH] DRM depends on ???

[Dave Jones]

On Sat, May 28, 2005 at 11:39:00PM +0200, Geert Uytterhoeven wrote:
 > 
 > DRM depending on `AGP=n' is driving me crazy! How to make CONFIG_DRM not
 > eligible for selection on platforms that do not have AGP?
 > 
 > Since many of the core DRM files depend on PCI, add a dependency on PCI,
 > to minimize the damage.
 > 
 > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
 > 
 > --- linux-2.6.12-rc5/drivers/char/drm/Kconfig	2005-05-25 19:37:53.000000000 +0200
 > +++ linux-m68k-2.6.12-rc5/drivers/char/drm/Kconfig	2005-04-05 10:12:41.000000000 +0200
 > @@ -6,7 +6,7 @@
 >  #
 >  config DRM
 >  	tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)"
 > -	depends on AGP || AGP=n
 > +	depends on (AGP || AGP=n) && PCI

The whole dependancy seems like nonsense to me.
I think

	depends on PCI

is a lot more sensible.

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/