Re: [PATCH] SATA NCQ support

From: Jeff Garzik
Date: Fri May 27 2005 - 18:49:14 EST


Jens Axboe wrote:
On Fri, May 27 2005, Jeff Garzik wrote:

Jens Axboe wrote:

Actually, I didn't look far enough up - ata_scsi_qc_new() already
completes the command with QUEUE_FULL if ata_qc_new_init() fails. So
there's no bug, but perhaps it would be cleaner to move it to
ata_scsi_translate instead?

Ah, ok.

Yes, if you are in a cleaning mood, that would be a better location.


Always in a code cleaning mood - here it is against vanilla, I've
integrated it in the ncq stuff as well.

Committed to 'ncq' branch of libata-dev.git.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/