Re: waitid() fails with EINVAL for SA_RESTART signals

From: Linus Torvalds
Date: Thu May 26 2005 - 18:18:20 EST




On Thu, 26 May 2005, David S. Miller wrote:
>
> > Other machines are subject to the same risk and should have a
> > prevent_tail_call definition too. The asm-i386/linkage.h version probably
> > works fine for every machine. It might as well be generic, I'd say.
>
> Sparc, for one, doesn't need it. We pass the pt_regs in via a pointer
> to the trap level stack frame which won't be released by a tail-call
> in C code.

x86 has largely tried to move in that direction too, ie a lot of the
asm-calls have been turned into FASTCALL() with %eax pointing to the
stack.

Roland, I applied the patch, but if there was some particular case that
triggered this, maybe it's worth trying to re-write that one.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/