Re: 2.6.12-rc2: Compose key doesn't work

From: Vojtech Pavlik
Date: Thu May 26 2005 - 07:28:21 EST


On Thu, May 26, 2005 at 02:23:15PM +0200, Domen Puncer wrote:

> Still true for 2.6.12-rc5. Should probably be fixed before final.

Caused by a bug in the atkbd-scroll feature. The attached patch
fixes it.

> On 14/04/05 12:04 +0200, Domen Puncer wrote:
> > On 10/04/05 11:52 +0200, Rene Herman wrote:
> > > Hi Vojtech.
> > >
> > > I have mapped my right windows key to "Compose" in X:
> > ...
> > >
> > > This worked fine upto 2.6.11.7, but doesn't under 2.6.12-rc2. The key
> > > doesn't seem to be doing anything anymore: "Compose-'-e" just gets me
> > > "'e" and so on.
> >
> > I can confirm this, right windows key works as scroll up, so it might
> > be related to recent scroll patches.
> >
> > A quick workaround is to:
> > echo -n "0" > /sys/bus/serio/devices/serio1/scroll
> >
> > serio1 being the keyboard here.
> >
> > Btw. is that "-n" really necessary? Had too look at the code to figure
> > out why it's not working :-)
> >
> > >
> > > X is X.org 6.8.1, keyboard is regular PS/2 keyboard, directly connected.
> >
> > Same here.
>

--
Vojtech Pavlik
SuSE Labs, SuSE CR
ChangeSet@xxxxxxxxxx, 2005-04-04 15:37:45+02:00, vojtech@xxxxxxx
input: Fix fast scrolling scancodes in atkbd.c

Signed-off-by: Vojtech Pavlik <vojtech@xxxxxxx>


atkbd.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)


diff -Nru a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
--- a/drivers/input/keyboard/atkbd.c 2005-05-03 15:23:34 +02:00
+++ b/drivers/input/keyboard/atkbd.c 2005-05-03 15:23:34 +02:00
@@ -171,9 +171,9 @@
unsigned char set2;
} atkbd_scroll_keys[] = {
{ ATKBD_SCR_1, 0xc5 },
- { ATKBD_SCR_2, 0xa9 },
- { ATKBD_SCR_4, 0xb6 },
- { ATKBD_SCR_8, 0xa7 },
+ { ATKBD_SCR_2, 0x9d },
+ { ATKBD_SCR_4, 0xa4 },
+ { ATKBD_SCR_8, 0x9b },
{ ATKBD_SCR_CLICK, 0xe0 },
{ ATKBD_SCR_LEFT, 0xcb },
{ ATKBD_SCR_RIGHT, 0xd2 },