Re: [patch 07/16] ide-disk: Fix LBA8 DMA

[Chuck Ebbert]

On Wed, 25 May 2005 at 03:57:14 -0400, Chuck Ebbert wrote:

> On Mon, 23 May 2005 at 16:24:14 -0700, Chris Wright wrote:
> 
> > --- linux-2.6.11.10.orig/drivers/ide/ide-disk.c       2005-05-16 10:50:31.000000000 -0700
> > +++ linux-2.6.11.10/drivers/ide/ide-disk.c    2005-05-20 09:36:31.933319224 -0700
> > @@ -133,6 +133,8 @@
> >       if (hwif->no_lba48_dma && lba48 && dma) {
> >               if (block + rq->nr_sectors > 1ULL << 28)
> 
>                                            ^
> 
>   Maybe I'm an idiot, but shouldn't that be ">="?  Either that or it should be
> comparing to (1ULL < 28 - 1)?


  Oops, I forgot this was in my outbox and sent it before review.  This code
is fine... (block + rq->nr_sectors) is one past the actual end of the read.


> >                       dma = 0;
> > +               else
> > +                       lba48 = 0;
> 
>    ^^^^^^^^^^^^^^^^^^^^^^^
> 
>   Spaces instead of tabs?

  But the patch really does seem to be tabdamaged...




--
Chuck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/