Re: 2.6.12-rc4-mm2 build failure

[Christoph Lameter]

On Wed, 18 May 2005, Matthew Dobson wrote:

> I think you explained it well yourself.  If another function needs to be
> added for ALL ARCHES, then ALL ARCHES will need to add the function.  In
> most cases there is no single function that is both CORRECT and GENERIC
> across all arches.  The way that i386, ia64, ppc64, etc. will map PCI Buses
> to Nodes (for instance) will NOT be the same.  Anyone who adds a new
> topology function has the responsibility of
> 1) making sure it works for all arches which support topology, or
> 2) getting the arch maintainers involved and helping them make sure it
> works for all arches.

The topology function in generic may just do nothing
if not defined by the arch like pcibus_to_node. If the arch does not
define it return indeterminate and make all node specific allocations fall
back to unspecific allocation. This works for all arches and preserves
the existing behavior.

> New topology functions don't really get added all that often.  We've got
> the basics (CPU, Mem, I/O Buses, Nodes) mapped in various ways, so there
> shouldn't be tons of new functions added.  If someone wants to add a new
> function, it's their responsibility to make sure that it doesn't break
> anyone's arch.

Its best to have the kernel setup in such a way that functions can be 
added without having to cause breakage.

It is imaginable that someone will add more hardware something to node
functions in the near future given that pcibus_to_node is just for pci.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/