RE: [RFC][PATCH] timers fixes/improvements

[Sy, Dely L]

On Friday, May 13, 2005 3:36 PM, Greg KH wrote:
> > The definition of GET_INDEX is suspect:
> > 
> > #define GET_INDEX(a, b) (((a - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) +
b)
> > 
> > should this not be
> > 
> > #define GET_INDEX(a, b) ((((a) - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) +
\
> > 				((b) & 7))
> > 
> > ?
>
> Dely, any thoughts about this, or know who would know about it?

Greg,

I looked at the code and talked with Steve on this.  The fix is correct;
i.e. b has to be masked with 7.  Would Christoph or you send out a 
patch for the fix or would you like us to do so?  Thanks for finding out

the problem.

Thanks,
Dely
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/