Re: [PATCH 4/8] ppc64: add BPA platform type

From: Paul Mackerras
Date: Tue May 17 2005 - 02:27:59 EST


Arnd Bergmann writes:

> This adds the basic support for running on BPA machines.
> So far, this is only the IBM workstation, and it will
> not run on others without a little more generalization.

> +/* FIXME: consolidate this into rtas.c or similar */
> +static void __init pSeries_calibrate_decr(void)

Shouldn't this be called bpa_calibrate_decr or something similar?

> -#define PV_630 0x0040
> -#define PV_630p 0x0041
> +#define PV_630 0x0040
> +#define PV_630p 0x0041

Hmmm, I don't think your patch needs to clean up the whitespace here.

Regards,
Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/