Re: [PATCH 7/8] ppc64: SPU file system

[Greg KH]

On Mon, May 16, 2005 at 01:14:58PM -0700, Roland Dreier wrote:
>     Greg> No, as Ben said, do not do this.  Use write.  And as you are
>     Greg> only doing 1 type of ioctl, it shouldn't be an issue.  Also
>     Greg> it will be faster than the ioctl due to lack of BKL usage :)
> 
> This is no longer true.  ioctls don't have to take the BKL now that
> struct file_operations has unlocked_ioctl and compat_ioctl.

Yes, but his patch did not use them :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/