Re: [patch 1/1] Uml: kludgy compilation fixes for x86-64 subarch modules support [for -mm]

[Andi Kleen]

On Sun, May 01, 2005 at 08:45:15PM +0200, blaisorblade@xxxxxxxx wrote:
> 
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>
> Cc: Andi Kleen <ak@xxxxxxx>
> 
> These are some trivial fixes for the x86-64 subarch module support. The only
> potential problem is that I have to modify arch/x86_64/kernel/module.c, to
> avoid copying the whole of it.
> 
> I can't use it verbatim because it depends on a special vmalloc-like area for
> modules, which for now (maybe that's to fix, I guess not) UML/x86-64 has not.
> I went the easy way and reused the i386 vmalloc()-based allocator.

Patch is ok for me. Another way would have been to use __attribute__((weak)),
but I guess the ifdef is ok too.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/