Re: [patch] properly stop devices before poweroff

From: Adam Belay
Date: Sun May 01 2005 - 17:30:08 EST


On Thu, Apr 21, 2005 at 01:13:46PM +0200, Pavel Machek wrote:
>
> Without this patch, Linux provokes emergency disk shutdowns and
> similar nastiness. It was in SuSE kernels for some time, IIRC.
>
> Signed-off-by: Pavel Machek <pavel@xxxxxxx>

Hi Pavel,

Although I like using pm_message_t, I'm not sure if we want to commit to only
PMSG_SUSPEND and PMSG_FREEZE for shutdown and reboot. Would it be possible
to create a PMSG_HALT and PMSG_REBOOT? I think this would give drivers more
control and flexability to make the right decision. What is your opinion?

Of course, I'm still considering the posibility that we really want to do
PMSG_SUSPEND on a shutdown. This may work ok on X86, I'm not sure about other
architectures.

I know you mentioned previously adding more flags and data to pm_message_t,
what exactly are your plans?

Thanks,
Adam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/