Re: Deferred handling of writes to /proc/irq/xx/smp_affinity

From: Greg KH
Date: Thu Apr 28 2005 - 01:03:45 EST


On Wed, Apr 27, 2005 at 10:15:38PM -0700, Ashok Raj wrote:
> Hi Andrew and all
>
> It is safe to re-program rte entries in ioapic only when an intr is pending.
> Existing code does this incorrectly by reprogamming rte entries immediatly
> when a value is written to /proc/irq/xx/smp_affinity. IRQ_BALANCE code in
> kernel does this right, but /proc/irq needs to be handled the same way so that
> user mode irq_balancer wont lock up systems or loose interrupts in the race.
>
> This is already fixed in ia64, introduced for i386 and x86_64.
>
> since this touches 3 arch's managing in -mm for trial would be best to make
> sure nothing is broken, before considering for main line.

The pci/msi stuff looks fine with me, as long as you've tested it out (I
have no msi hardware...)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/