Re: [patch] __block_write_full_page bug

From: Andrew Morton
Date: Tue Apr 26 2005 - 06:53:53 EST


Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
>
> When running
> fsstress -v -d $DIR/tmp -n 1000 -p 1000 -l 2
> on an ext2 filesystem with 1024 byte block size, on SMP i386 with 4096 byte
> page size over loopback to an image file on a tmpfs filesystem, I would
> very quickly hit
> BUG_ON(!buffer_async_write(bh));
> in fs/buffer.c:end_buffer_async_write
>
> It seems that more than one request would be submitted for a given bh
> at a time. __block_write_full_page looks like the culprit - with the
> following patch things are very stable.

What's the bug? I don't see it.

Was an ENOSPC involved?

Those tests for buffer_async_write(bh) are redundant now, aren't they?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/