Re: [patch 1/1] uml ubd: handle readonly status

From: Jeff Dike
Date: Mon Apr 25 2005 - 16:51:19 EST


On Mon, Apr 25, 2005 at 09:19:49PM +0200, blaisorblade@xxxxxxxx wrote:
> + /* This should no more be needed. And it didn't work anyway to exclude
> + * read-write remounting of filesystems.*/
> + /*if((filp->f_mode & FMODE_WRITE) && !dev->openflags.w){
> if(--dev->count == 0) ubd_close(dev);
> err = -EROFS;
> - }
> + }*/

> + /* This should be impossible now */

> + /* This should be impossible now */

If code can't run any more because of now-impossible conditions, then just
delete it.

Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/